Messages in this thread | | | Date | Thu, 18 Jun 2015 13:49:30 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 06/51] memcg: add mem_cgroup_root_css |
| |
Hello, Michal.
On Thu, Jun 18, 2015 at 01:12:27PM +0200, Michal Hocko wrote: ... > I see and yes, it makes some sense. I just think we can get rid of the > accessor functions when the struct mem_cgroup is visible and the code > can simply do &{page->}mem_cgroup->css.
As long as the accessors are inline, I think it should be fine.
> I have tried to compile with !CONFIG_MEMCG and !CONFIG_CGROUP_WRITEBACK > without mem_cgroup_root_css defined for this configuration and > mm/backing-dev.c compiles just fine. So maybe we should get rid of it > rather than have a potentially tricky code?
Yeah, please feel free to queue a patch to remove it if doesn't break anything.
Thanks.
-- tejun
| |