Messages in this thread | | | Date | Thu, 18 Jun 2015 08:08:51 -0700 | From | York Sun <> | Subject | Re: [Patch v2] driver/i2c/mux: Add register based mux i2c-mux-reg |
| |
On 06/18/2015 05:35 AM, Alexander Sverdlin wrote: > Hello! > > On 17/06/15 23:13, ext York Sun wrote: >> + switch (mux->data.reg_size) { >> + case 4: >> + iowrite32(mux->data.values[chan], mux->data.reg); >> + break; >> + case 2: >> + iowrite16(mux->data.values[chan], mux->data.reg); >> + break; >> + case 1: >> + iowrite8(mux->data.values[chan], mux->data.reg); >> + break; > > I'd like to see at least [optional] read-back operation after each write.
Maybe I should add ioread after each write without using an option. I want to avoid additional option if possible.
> And if you stick with iowrite*(), maybe it desires a comment (in the Documentation/ file?), > that write will be little-Endian, therefore BE users must take care...
I am consulting with my colleagues. If I cannot come up with a native endianess solution, I will keep using iowrite and add a comment.
> > Other than that it looks good to me... >
Thanks.
York
| |