Messages in this thread Patch in this message | | | Date | Thu, 18 Jun 2015 07:55:05 -0700 | From | Tadeusz Struk <> | Subject | Re: crypto: rsa - select on undefined AKCIPHER |
| |
On 06/18/2015 01:26 AM, Andreas Ruprecht wrote: > Hi Tadeusz, > > your commit cfc2bb32b313 ("crypto: rsa - add a new rsa generic > implementation") was merged into linux-next today (i.e., next-20150618). > It changes the crypto/Kconfig file and adds the CRYPTO_RSA config option: > > +config CRYPTO_RSA > + tristate "RSA algorithm" > + select AKCIPHER > [...] > > The symbol AKCIPHER, however, is not defined in Kconfig. Did you maybe > mean CRYPTO_AKCIPHER, which you added in commit 3c339ab83fc0 ("crypto: > akcipher - add PKE API")? > > I detected the issue by running undertaker-checkpatch from the > Undertaker tool suite (https://undertaker.cs.fau.de) as part of an > automated, daily analysis of the most recent linux-next tree. > There is also a tool in the Linux tree itself that can detect such > issues (scripts/checkkconfigsymbols.py). Hi Andreas, Yes it should have been CRYPTO_AKCIPHER. Thanks for reporting this.
--- >8 --- This patch fixes invalid config selection for AKCIPHER
Reported-by: Andreas Ruprecht <andreas.ruprecht@fau.de> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com> ---
diff --git a/crypto/Kconfig b/crypto/Kconfig index 6c79ef0..b4cfc57 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@ -102,7 +102,7 @@ config CRYPTO_AKCIPHER config CRYPTO_RSA tristate "RSA algorithm" - select AKCIPHER + select CRYPTO_AKCIPHER select MPILIB select ASN1 help
| |