Messages in this thread | | | Date | Thu, 18 Jun 2015 16:19:25 +0200 | Subject | Re: [PATCH 1/2] clocksource: sh_cmt: Only perform clocksource suspend/resume if enabled | From | Geert Uytterhoeven <> |
| |
Hi Laurent,
On Thu, Jun 18, 2015 at 4:14 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Thursday 18 June 2015 12:22:33 Geert Uytterhoeven wrote: >> Currently the sh_cmt clocksource timer is disabled or enabled >> unconditionally on clocksource suspend resp. resume, even if a better >> clocksource is present (e.g. arch_sys_counter) and the sh_cmt >> clocksource is not enabled.
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Good catch. The patch looks good to me.
While the solution was simple, it was hard to catch (engineers and lightbulbs... euh timers ;-)
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks!
> I've quickly checked the MTU2 and TMU timer drivers and they should be immune > to the issue, but I'd appreciate if you could confirm that.
I had concluded the same, thanks for verifying!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |