lkml.org 
[lkml]   [2015]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3.4 035/172] ALSA: hdspm - Constrain periods to 2 on older cards
>> @@ -6042,6 +6042,12 @@ static int snd_hdspm_capture_open(struct snd_pcm_substream *substream)
>> snd_pcm_hw_constraint_minmax(runtime,
>> SNDRV_PCM_HW_PARAM_PERIOD_SIZE,
>> 64, 8192);
>> + snd_pcm_hw_constraint_minmax(runtime,
>> + SNDRV_PCM_HW_PARAM_PERIODS,
>> + 2, 2);
>> + snd_pcm_hw_constraint_minmax(runtime,
>> + SNDRV_PCM_HW_PARAM_PERIODS,
>> + 2, 2);
>> break;
>> }
>
> This is not correct, those lines need to go to two different functions
> (snd_hdspm_playback_open and snd_hdspm_capture_open).
>
> Here is how the patch should look like:
>

Now fixed. Thanks for review the patch.



\
 
 \ /
  Last update: 2015-06-18 05:41    [W:0.147 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site