Messages in this thread | | | Date | Wed, 17 Jun 2015 16:22:46 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [RFC][PATCH 3/5] mm/dmapool: allow NULL `pool' pointer in dma_pool_destroy() |
| |
On Tue, 9 Jun 2015, Sergey Senozhatsky wrote:
> dma_pool_destroy() does not tolerate a NULL dma_pool pointer > argument and performs a NULL-pointer dereference. This requires > additional attention and effort from developers/reviewers and > forces all dma_pool_destroy() callers to do a NULL check > > if (pool) > dma_pool_destroy(pool); > > Or, otherwise, be invalid dma_pool_destroy() users. > > Tweak dma_pool_destroy() and NULL-check the pointer there. > > Proposed by Andrew Morton. > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> > Reported-by: Andrew Morton <akpm@linux-foundation.org> > LKML-reference: https://lkml.org/lkml/2015/6/8/583
Acked-by: David Rientjes <rientjes@google.com>
| |