| Date | Wed, 17 Jun 2015 11:42:26 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v3 02/18] x86/msr/kvm: Remove vget_cycles() |
| |
On Tue, Jun 16, 2015 at 05:35:50PM -0700, Andy Lutomirski wrote: > The only caller was kvm's read_tsc. The only difference between > vget_cycles and native_read_tsc was that vget_cycles returned zero > instead of crashing on TSC-less systems. KVM's already checks > vclock_mode before calling that function, so the extra check is > unnecessary. > > (Off-topic, but the whole KVM clock host implementation is gross. > IMO it should be rewritten.) > > Signed-off-by: Andy Lutomirski <luto@kernel.org> > --- > arch/x86/include/asm/tsc.h | 13 ------------- > arch/x86/kvm/x86.c | 2 +- > 2 files changed, 1 insertion(+), 14 deletions(-)
Acked-by: Borislav Petkov <bp@suse.de>
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
|