Messages in this thread | | | From | Ashley Lai <> | Date | Tue, 16 Jun 2015 20:17:56 -0500 (CDT) | Subject | Re: [PATCH v2 1/2] vTPM: support little endian guests |
| |
Just a small comment otherwise it looks good.
On Tue, 9 Jun 2015, Hon Ching(Vicky) Lo wrote: > case NONHOST_INFO: > - name = tcpa_event_type_strings[event->event_type]; > + name = > + tcpa_event_type_strings[do_endian_conversion > + (event->event_type)]; Not being picky but if it does not exceed 80 characters it looks better to join the line above. name = tcpa_event_type_strings[do_endian_conversion (event->event_type)];
> case POST_CONTENTS: > - name = tcpa_pc_event_id_strings[pc_event->event_id]; > + name = > + tcpa_pc_event_id_strings[do_endian_conversion > + (pc_event->event_id)]; Same as above.
Thanks, --Ashley Lai
| |