Messages in this thread Patch in this message | | | From | Julien Grall <> | Subject | [PATCH v4 1/3] net/xen-netfront: Correct printf format in xennet_get_responses | Date | Tue, 16 Jun 2015 20:10:46 +0100 |
| |
rx->status is an int16_t, print it using %d rather than %u in order to have a meaningful value when the field is negative.
Also use %u rather than %x for rx->offset.
Signed-off-by: Julien Grall <julien.grall@citrix.com> Reviewed-by: David Vrabel <david.vrabel@citrix.com> Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: netdev@vger.kernel.org
--- Changes in v4: - Use %u for the rx->offset because offset is unsigned
Changes in v3: - Use %d for the rx->offset too.
Changes in v2: - Add David's Reviewed-by --- drivers/net/xen-netfront.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index e031c94..281720f 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -733,7 +733,7 @@ static int xennet_get_responses(struct netfront_queue *queue, if (unlikely(rx->status < 0 || rx->offset + rx->status > PAGE_SIZE)) { if (net_ratelimit()) - dev_warn(dev, "rx->offset: %x, size: %u\n", + dev_warn(dev, "rx->offset: %u, size: %d\n", rx->offset, rx->status); xennet_move_rx_slot(queue, skb, ref); err = -EINVAL; -- 2.1.4
| |