lkml.org 
[lkml]   [2015]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/5] pcmcia: handle anonymous cards by generating a fake CIS
On Mon, Jun 15, 2015 at 01:10:55PM +0100, Alan Cox wrote:
> > Unfortunately, this patch does not work well with all of the callers of
> > pccard_validate_cis(). While it helps for ds.c:pcmcia_card_add() and does
> > not matter for cistpl.c:pccard_show_cis(), it breaks the callback in
> > rsrc_nonstatic.c:readable():
>
> I'm not sure it's the right way to do readable() but we seem to be stuck
> with that anyway.

Indeed - any replacement would need much testing at least.
>
> The change looks good to me, and I will try and test it soon but it may
> take some time due to various other things going on in life. Can you
> submit it for 4.2 anyway and give it a bit of time for any screaming
> then push to stable ?

Have added it to my tree, and will do as you suggest.

Thanks,

Dominik


\
 
 \ /
  Last update: 2015-06-16 09:21    [W:0.271 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site