lkml.org 
[lkml]   [2015]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.4 129/172] selinux: fix sel_write_enforce broken return value
    Date
    From: Joe Perches <joe@perches.com>

    3.4.108-rc1 review patch. If anyone has any objections, please let me know.

    ------------------


    commit 6436a123a147db51a0b06024a8350f4c230e73ff upstream.

    Return a negative error value like the rest of the entries in this function.

    Signed-off-by: Joe Perches <joe@perches.com>
    Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
    [PM: tweaked subject line]
    Signed-off-by: Paul Moore <pmoore@redhat.com>
    Signed-off-by: Zefan Li <lizefan@huawei.com>
    ---
    security/selinux/selinuxfs.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/security/selinux/selinuxfs.c b/security/selinux/selinuxfs.c
    index 0a9891e..3bf9045 100644
    --- a/security/selinux/selinuxfs.c
    +++ b/security/selinux/selinuxfs.c
    @@ -150,7 +150,7 @@ static ssize_t sel_write_enforce(struct file *file, const char __user *buf,
    goto out;

    /* No partial writes. */
    - length = EINVAL;
    + length = -EINVAL;
    if (*ppos != 0)
    goto out;

    --
    1.9.1


    \
     
     \ /
      Last update: 2015-06-16 11:01    [W:4.090 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site