Messages in this thread | | | From | Xiao Guangrong <> | Subject | [PATCH v2 00/15] vMTRR bugfix and optimization | Date | Mon, 15 Jun 2015 16:55:20 +0800 |
| |
Changlog: - let's fix the bugs for noncoherent_dma guests first
- these changes are from Paolo's review 1) use inline functions instead of union definition for 'struct kvm_mtrr' 2) improve code style 3) fix fixed_msr_to_range_index which does not return the actual value 4) introduce kvm_set_var_mtrr() to make the code more clearer 5) improve mtrr_for_each_mem_type() APIs and clean it up 6) drop @unit_size in 'struct fixed_mtrr_segment'
- these changes are from David Matlack's review 1) improve comment 2) fix fixed_mtrr_range_end_addr that did not count entries correctly
There are some bugs in current code if noncoherent_dma is detected: - KVM still uses hugepage even if the 4K pages in that ranges span between on different memory types and uses the cache type of first page to do memory mapping
- CR0.CD is not checked so that guest memory is not UC as it expected
This patchset fixes these bugs and also do optimization and cleanups.
Xiao Guangrong (15): KVM: x86: fix CR0.CD virtualization KVM: x86: move MTRR related code to a separate file KVM: MTRR: handle MSR_MTRRcap in kvm_mtrr_get_msr KVM: MTRR: remove mtrr_state.have_fixed KVM: MTRR: exactly define the size of variable MTRRs KVM: MTRR: clean up mtrr default type KVM: MTRR: do not split 64 bits MSR content KVM: MTRR: improve kvm_mtrr_get_guest_memory_type KVM: MTRR: introduce fixed_mtrr_segment table KVM: MTRR: introduce var_mtrr_range KVM: MTRR: sort variable MTRRs KVM: MTRR: introduce fixed_mtrr_addr_* functions KVM: MTRR: introduce mtrr_for_each_mem_type KVM: MTRR: simplify kvm_mtrr_get_guest_memory_type KVM: MTRR: do not map huage page for non-consistent range
arch/x86/include/asm/kvm_host.h | 17 +- arch/x86/kvm/Makefile | 2 +- arch/x86/kvm/mmu.c | 123 ++----- arch/x86/kvm/mtrr.c | 708 ++++++++++++++++++++++++++++++++++++++++ arch/x86/kvm/vmx.c | 32 +- arch/x86/kvm/x86.c | 223 +------------ arch/x86/kvm/x86.h | 6 + 7 files changed, 778 insertions(+), 333 deletions(-) create mode 100644 arch/x86/kvm/mtrr.c
-- 2.1.0
| |