Messages in this thread | | | Date | Mon, 15 Jun 2015 14:41:29 -0700 | From | Guenter Roeck <> | Subject | Re: [RESEND PATCH 0/3] watchdog: MAX63xx cleanup and platform settings |
| |
On 06/15/2015 12:58 PM, Vivien Didelot wrote: > The first version of this patchset from January, 29 [1] got no feedback > from the maintainer. 1/4 [2] was applied to watchdog-next on May, 30 > though. A concern about constants removal was raised in the preliminary > 2/4 cleanup patch, the explanation has been added to the related commit > message. >
Hi Vivien,
For my part, adding a comment about removal of constants does not alleviate my concern about removing those constants. I just don't believe that removing constants is a good idea, no matter what the arguments for doing so might be.
Thanks, Guenter
| |