Messages in this thread | | | Date | Mon, 15 Jun 2015 09:35:01 +0200 | From | Jesper Nilsson <> | Subject | Re: [PATCH] cris: don't use module_init for non-modular core eeprom.c code |
| |
On Sun, Jun 14, 2015 at 05:05:21PM -0400, Paul Gortmaker wrote: > The eeprom.c code is compiled based on the Kconfig setting > ETRAX_I2C_EEPROM, which is bool. So the code is either built in > or absent. It will never be modular, so using module_init as an > alias for __initcall is rather misleading. > > Fix this up now, so that we can relocate module_init from > init.h into module.h in the future. If we don't do this, we'd > have to add module.h to obviously non-modular code, and that > would be a worse thing. > > Direct use of __initcall is discouraged, vs prioritized ones. > Use of device_initcall is consistent with what __initcall > maps onto, and hence does not change the init order, making the > impact of this change zero. Should someone with real hardware > for boot testing want to change it later to arch_initcall or > something different, they can do that at a later date. > > Cc: Mikael Starvik <starvik@axis.com>
Looks good, I'll take it in the CRIS-tree.
> Cc: linux-cris-kernel@axis.com > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
/^JN - Jesper Nilsson -- Jesper Nilsson -- jesper.nilsson@axis.com
| |