lkml.org 
[lkml]   [2015]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 4/6] drivers:hv: Export a function that maps Linux proc num onto Hyper-V proc num
Date


> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Monday, June 15, 2015 12:52 PM
> To: Jake Oshins
> Cc: KY Srinivasan; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
> vkuznets@redhat.com; bhelgaas@google.com; linux-pci@vger.kernel.org;
> pebolle@tiscali.nl; Haiyang Zhang; Mike Ebersol
> Subject: Re: [PATCH v2 4/6] drivers:hv: Export a function that maps Linux
> proc num onto Hyper-V proc num
>
> > +/**
> > + * This function returns the mapping between the Linux processor
> > + * number and
> > + * the hypervisor's virtual processor number, useful in making
> > + * hypercalls and such that talk about specific processors.
> > + *
> > + * @param procnum - in Linux terms
>
> What kind of comment structure is this? It's not kernel doc :(
>
> And "procnum" sounds like "process number", why not "cpu_number"?

Thanks. I'll wait a little while to see if any other feedback comes in and then I'll fix these and resend.

-- Jake Oshins



\
 
 \ /
  Last update: 2015-06-15 23:41    [W:0.170 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site