lkml.org 
[lkml]   [2015]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ideapad: add rfkill whitelist entry for Yoga 3 1170
On Sat, Jun 13, 2015 at 03:24:32PM +0200, Arnd Bergmann wrote:
> This adds one more entry to the whitelist of machines that do not have
> a physical rfkill switch. Unfortunately, the Yoga 3 generation seems
> to use upper-case letters for the YOGA 3 Pro-1370, while it uses normal
> capitalization for its Yoga 3 1170 sibling.
>
> In order to catch all variants of the Yoga 3, I'm now using both strings
> as wildcards here, which should also cover the 1470 model, and possible
> changes in the string that could happen in firmware updates.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index cb7cd8d79329..8e455c1429ee 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -855,7 +855,14 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
> .ident = "Lenovo Yoga 3 Pro 1370",

I believe we should also update the ident to indicate the inclusion of the 1470
model since you dropped the 1370 specifier from the product version.

(Also, please use my infradead ID specified in MAINTAINERS for
platform-drivers-x86)

Thanks,

> .matches = {
> DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> - DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 3 Pro-1370"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 3"),
> + },
> + },
> + {
> + .ident = "Lenovo Yoga 3 1170 / 1470",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> + DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo Yoga 3"),
> },
> },
> {}
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
Darren Hart
Intel Open Source Technology Center


\
 
 \ /
  Last update: 2015-06-15 22:41    [W:0.063 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site