lkml.org 
[lkml]   [2015]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] jbd2: get rid of open coded allocation retry loop
On Mon 15-06-15 15:47:04, Theodore Ts'o wrote:
> On Mon, Jun 15, 2015 at 04:17:34PM +0200, Michal Hocko wrote:
> > insert_revoke_hash does an open coded endless allocation loop if
> > journal_oom_retry is true. It doesn't implement any allocation fallback
> > strategy between the retries, though. The memory allocator doesn't know
> > about the never fail requirement so it cannot potentially help to move
> > on with the allocation (e.g. use memory reserves).
> >
> > Get rid of the retry loop and use __GFP_NOFAIL instead. We will lose the
> > debugging message but I am not sure it is anyhow helpful.
> >
> > Do the same for journal_alloc_journal_head which is doing a similar
> > thing.
> >
> > Signed-off-by: Michal Hocko <mhocko@suse.cz>
>
> Thanks, applied.

Thanks!
--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2015-06-15 22:21    [W:1.016 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site