Messages in this thread | | | Date | Mon, 15 Jun 2015 21:44:47 +0200 | Subject | Re: [PATCH v2 12/14] drivers: sh: Stop using pm_runtime.c for multi-platform shmobile with genpd | From | Geert Uytterhoeven <> |
| |
On Thu, May 28, 2015 at 8:53 PM, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > Now most multi-platform ARM shmobile platforms (SH-Mobile, R-Mobile, > R-Car, RZ) use the CPG Clock Domain to take care of PM runtime > management of the module clocks, we no longer need the legacy default PM > domain hack, which also prevented registering the real PM domain. > > EMMA Mobile EV2 doesn't have MSTP clocks and doesn't use the CPG Clock > Domain. But all its device drivers manage clocks explicitly, without > relying on Runtime PM, so it doesn't need the legacy default PM hack > neither. > > Hence do not compile it when running an ARM multi-platform kernel with > genpd support. > > The default PM domain is still needed: > - for legacy SuperH, > - for legacy (non-DT) ARM/shmobile platforms > - without genpd support (r8a7778, r8a7779), > - with genpd support, for devices in the "C5" always-on power > area (r8a7740, sh73a0), > - for the CONFIG_PM=n case. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > v2: > - Add Reviewed-by, > - Just stop compiling pm_runtime.c instead of using a runtime check, > as no multi-platform ARM platforms need this anymore.
The runtime check must stay for the ARM multiplatform CONFIG_PM=n case, to prevent the code from running on non-shmobile machines. Will fix.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |