lkml.org 
[lkml]   [2015]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 2/2] dma: Add Xilinx zynqmp dma engine driver support
Date


> -----Original Message-----
> From: Shubhrajyoti Datta [mailto:omaplinuxkernel@gmail.com]
> Sent: Monday, June 15, 2015 8:35 PM
> To: Punnaiah Choudary Kalluri
> Cc: robh+dt@kernel.org; pawel.moll@arm.com; mark.rutland@arm.com;
> ijc+devicetree@hellion.org.uk; Kumar Gala; Michal Simek; Soren Brinkmann;
> vinod.koul@intel.com; dan.j.williams@intel.com;
> devicetree@vger.kernel.org; Linux Kernel Mailing List; kpc528@gmail.com;
> kalluripunnaiahchoudary@gmail.com; dmaengine@vger.kernel.org;
> Punnaiah Choudary Kalluri; linux-arm-kernel@lists.infradead.org
> Subject: Re: [PATCH v2 2/2] dma: Add Xilinx zynqmp dma engine driver
> support
>
> On Mon, Jun 15, 2015 at 8:06 PM, Punnaiah Choudary Kalluri
> <punnaiah.choudary.kalluri@xilinx.com> wrote:
> > Added the basic driver for zynqmp dma engine used in Zynq
> > UltraScale+ MPSoC. The initial release of this driver supports
> > only memory to memory transfers.
> >
> > Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xilinx.com>
> > ---
> <snip>
>
> > +/**
> > + * zynqmp_dma_chan_is_idle - Provides the channel idle status
> > + * @chan: ZynqMP DMA DMA channel pointer
> > + *
> > + * Return: '1' if the channel is idle otherwise '0'
> > + */
> > +static int zynqmp_dma_chan_is_idle(struct zynqmp_dma_chan *chan)
>
> maybe this could return bool.

Ok. I will modify the return type.

Regards,
Punnaiah
>
> > +{
> > + u32 regval;
> > +
> > + regval = readl(chan->regs + STATUS);
> > + if (regval & STATUS_BUSY)
> > + return 0;
> > +
> > + return 1;
> > +}
> > +
\
 
 \ /
  Last update: 2015-06-15 18:41    [W:0.050 / U:0.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site