lkml.org 
[lkml]   [2015]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1] ARM: zynq: Fix earlyprintk in big endian mode
From
On Thu, Jun 11, 2015 at 11:43 PM, Michal Simek <michal.simek@xilinx.com> wrote:
> On 06/10/2015 04:13 PM, Arun Chandran wrote:
>> earlyprintk messages are not appearing on the terminal
>> emulator during a big endian kernel boot. If we
>> byte swap the sending data it comes properly.
>>
>> Signed-off-by: Arun Chandran <achandran@mvista.com>
>> ---
>> ---
>> This can be tested by adding 'early_print("early print test\n");'
>> to setup_arch() in arch/arm/kernel/setup.c
>> ---
>> arch/arm/include/debug/zynq.S | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/include/debug/zynq.S b/arch/arm/include/debug/zynq.S
>> index bd13ded..0d274fe 100644
>> --- a/arch/arm/include/debug/zynq.S
>> +++ b/arch/arm/include/debug/zynq.S
>> @@ -38,6 +38,7 @@
>> .endm
>>
>> .macro senduart,rd,rx
>> +ARM_BE8( rev \rd, \rd )
>> str \rd, [\rx, #UART_FIFO_OFFSET] @ TXDATA
>> .endm
>>
>>
>
> Tested-by: Michal Simek <michal.simek@xilinx.com>
>

I think just using strb instead of str will do the work
much better. I have send v2 with that logic

Thanks for testing it.

--Arun


\
 
 \ /
  Last update: 2015-06-12 09:41    [W:0.111 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site