Messages in this thread | | | Date | Thu, 11 Jun 2015 21:29:06 -0700 | From | Greg KH <> | Subject | Re: [PATCH] extcon: Redefine the unique id of supported external connectors without 'enum extcon' type |
| |
On Fri, Jun 12, 2015 at 11:10:06AM +0900, Chanwoo Choi wrote: > This patch just redefine the unique id of supported external connectors without > 'enum extcon' type. Because unique id would be used on devictree file(*.dts) to > indicate the specific external connectors like key number of input framework. > So, I have the plan to move this definitions to following header file which > includes the unique id of supported external connectors. > - include/dt-bindings/extcon/extcon.h
Do we have other such fields in dt-bindings that are not enumerated types?
What's wrong with keeping this as-is and not changing to an integer?
> Fixes: 2a9de9c0f08d ("extcon: Use the unique id for external connector instead of string")
How is this a bugfix?
confused,
greg k-h
| |