lkml.org 
[lkml]   [2015]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] powerpc/rcpm: add RCPM driver
From
Date
Just a nit.

On Thu, 2015-06-11 at 14:32 +0800, Yuantian.Tang@freescale.com wrote:
> --- /dev/null
> +++ b/arch/powerpc/sysdev/fsl_rcpm.c

> +int fsl_rcpm_init(void)

This is used only through early_initcall(). I took the cargo cult
approach of looking at the other uses of early_initcall() in
arch/powerpc/. That approach tells me this function could be static and
marked as __init. Would that work here too?

> +{
> + [...]
> +}
> +
> +/* need to call this before SMP init */
> +early_initcall(fsl_rcpm_init);

Thanks,

Paul Bolle



\
 
 \ /
  Last update: 2015-06-12 11:41    [W:0.060 / U:0.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site