lkml.org 
[lkml]   [2015]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] x86, mwaitt: introduce mwaix delay with a configurable timer
On Fri, Jun 12, 2015 at 10:30:33AM +0200, Borislav Petkov wrote:
> On Fri, Jun 12, 2015 at 03:50:33PM +0800, Huang Rui wrote:
> > Yeah, but I remembered at last time, someone tell me we shouldn't
> > force to set timer always enabled. So I add this interface to expose
> > more clearly. :)
>
> Yeah, but this interface would make users go and look at it and try to
> remember what the enable parameter stood for.
>
> > So could I use __mwaitx directly like below:
> >
> > __monitorx(&dummy, 0, 0);
> > __mwaitx(0xf, delay, MWAITX_ECX_TIMER_ENABLE);
>
> Yes, this is more straight-forward and what the hardware instructions
> take, so more intuitive.
>

OK, will do it. :)

Thanks,
Rui


\
 
 \ /
  Last update: 2015-06-12 10:41    [W:1.048 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site