Messages in this thread | | | Date | Fri, 12 Jun 2015 16:23:21 +0800 | From | Huang Rui <> | Subject | Re: [PATCH v3 2/2] x86, mwaitt: introduce mwaix delay with a configurable timer |
| |
On Fri, Jun 12, 2015 at 10:30:33AM +0200, Borislav Petkov wrote: > On Fri, Jun 12, 2015 at 03:50:33PM +0800, Huang Rui wrote: > > Yeah, but I remembered at last time, someone tell me we shouldn't > > force to set timer always enabled. So I add this interface to expose > > more clearly. :) > > Yeah, but this interface would make users go and look at it and try to > remember what the enable parameter stood for. > > > So could I use __mwaitx directly like below: > > > > __monitorx(&dummy, 0, 0); > > __mwaitx(0xf, delay, MWAITX_ECX_TIMER_ENABLE); > > Yes, this is more straight-forward and what the hardware instructions > take, so more intuitive. >
OK, will do it. :)
Thanks, Rui
| |