lkml.org 
[lkml]   [2015]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH V2 0/7] clockevent: Migrate to new 'set-state' interface
Date
Hi Thomas/Daniel,

I have incorporated all the improvements Daniel suggested on V1 and so
here is V2.

The first patch allows set-state callbacks to be optional, otherwise it
leads to unnecessary noop callbacks for drivers which don't want to
implement them. Over that, these noop-callbacks result in full function
calls for nothing really useful.

Rest of the series converts few clockevent drivers to the new set-state
interface. This would enable these drivers to use new states (like:
ONESHOT_STOPPED, etc.) of a clockevent device (if required), as the
set-mode interface is marked obsolete now and wouldn't be expanded to
handle new states.

Once all the drivers are migrated to the new interface in future, we can
remove the code supporting '->mode' in clockevents core.

Drivers converted in this series are selected based on the diff they
generate. These are different diffs we shall have for most of the
drivers and any suggestions/improvements for these patches will be
applied to other drivers as well.

This is based of latest tip/master from few days back due to dependency
on clockevent_state_*() helpers.

Only the first patch is tested on hardware, others are ONLY compile
tested.

V1->V2:
- New commit: 1/7 (Daniel)
- Added all Acks from Daniel
- Updated 2/7 to return 0 directly from timer_shutdown()
- Naming fixes suggested for kona driver (Ray Jui)
- Minor changes in commit logs
- Not adding noop-callbacks

Cc: Andres Salomon <dilinger@queued.net>
Cc: bcm-kernel-feedback-list@broadcom.com
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Lee Jones <lee@kernel.org>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: Maxime Coquelin <maxime.coquelin@st.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@gmail.com>
Cc: Stephen Warren <swarren@wwwdotorg.org>

Viresh Kumar (7):
clockevents: Allow set-state callbacks to be optional
clocksource: arm_arch_timer: Migrate to new 'set-state' interface
clocksource: arm_global_timer: Migrate to new 'set-state' interface
clocksource: bcm2835: Migrate to new 'set-state' interface
clocksource: bcm_kona: Migrate to new 'set-state' interface
clocksource: cs5535: Migrate to new 'set-state' interface
clocksource: em_sti: Migrate to new 'set-state' interface

drivers/clocksource/arm_arch_timer.c | 52 ++++++++++++++--------------------
drivers/clocksource/arm_global_timer.c | 37 +++++++++++-------------
drivers/clocksource/bcm2835_timer.c | 16 -----------
drivers/clocksource/bcm_kona_timer.c | 17 ++++-------
drivers/clocksource/cs5535-clockevt.c | 24 +++++++++-------
drivers/clocksource/em_sti.c | 39 +++++++++----------------
kernel/time/clockevents.c | 24 ++++++----------
7 files changed, 81 insertions(+), 128 deletions(-)

--
2.4.0



\
 
 \ /
  Last update: 2015-06-12 10:21    [W:0.209 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site