Messages in this thread | | | Date | Thu, 11 Jun 2015 19:06:19 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH v2 2/4] rtc/lib: Introduce rtc_tm_subtract() helper function |
| |
Hi,
I'm fine with the whole series, I would just rename things a bit:
On 02/06/2015 at 17:04:20 +0800, Xunlei Pang wrote : > /* > + * rtc_tm_subtract - Return the difference in seconds. > + */ > +time64_t rtc_tm_subtract(struct rtc_time *minuend, struct rtc_time *subtrahend) > +{ > + return rtc_tm_to_time64(minuend) - rtc_tm_to_time64(subtrahend); > +} > +EXPORT_SYMBOL_GPL(rtc_tm_subtract); > + > +/* > * Convert rtc_time to ktime > */ > ktime_t rtc_tm_to_ktime(struct rtc_time tm) > diff --git a/include/linux/rtc.h b/include/linux/rtc.h > index 8dcf682..13e4138 100644 > --- a/include/linux/rtc.h > +++ b/include/linux/rtc.h > @@ -21,6 +21,8 @@ extern int rtc_year_days(unsigned int day, unsigned int month, unsigned int year > extern int rtc_valid_tm(struct rtc_time *tm); > extern time64_t rtc_tm_to_time64(struct rtc_time *tm); > extern void rtc_time64_to_tm(time64_t time, struct rtc_time *tm); > +extern time64_t rtc_tm_subtract(struct rtc_time *minuend, > + struct rtc_time *subtrahend);
I would use something closer to what is done for timespecs in time.h, like:
static inline time64_t rtc_tm_sub(struct rtc_time *lhs, struct rtc_time *rhs) { return rtc_tm_to_time64(lhs) - rtc_tm_to_time64(rhs); }
and not modify rtc-lib.c
Can you make that modification ?
-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
| |