lkml.org 
[lkml]   [2015]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] x86/asm/entry/32, selftests: Add test_syscall_vdso test
From
On Wed, Jun 10, 2015 at 1:15 PM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
> On 06/10/2015 10:00 PM, Kees Cook wrote:
>>> + printf("[SKIP]\tAT_SYSINFO not supplied, can't test\n");
>>> + exit(0); /* this is not a test failure */
>>
>> Why is that not a test failure? It would mean it didn't actually test
>> anything, which seems like a failure to me.
>
> Are you objecting to comment wording, or to exiting with 0?
>
> I exit with 0 because no bug was detected.

It seemed like a test failure to me: you're failing open ("couldn't
configure test, I guess everything is okay") instead of failing closed
("couldn't configure test, something is terribly wrong").

If you can't locate how to make a syscall, then the test should fail,
IMO, since it was not possible to perform the test, so you don't know
if flags are being correctly handled across syscalls.

-Kees

--
Kees Cook
Chrome OS Security


\
 
 \ /
  Last update: 2015-06-10 23:01    [W:0.062 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site