lkml.org 
[lkml]   [2015]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros
    On Wed, Jun 10, 2015 at 08:17:32PM +0200, Pavel Machek wrote:
    > On Wed 2015-06-10 07:06:09, Josh Poimboeuf wrote:
    > > Add the FP_SAVE and FP_RESTORE asm macros, which can be used to save and
    > > restore the frame pointer.
    >
    > Add a changelog, which can be used to tell what changed.

    Fair enough :-)

    > > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
    > > ---
    > > arch/x86/include/asm/func.h | 24 ++++++++++++++++++++++++
    > > 1 file changed, 24 insertions(+)
    > > create mode 100644 arch/x86/include/asm/func.h
    > >
    > > diff --git a/arch/x86/include/asm/func.h b/arch/x86/include/asm/func.h
    > > new file mode 100644
    > > index 0000000..4d62782
    > > --- /dev/null
    > > +++ b/arch/x86/include/asm/func.h
    > > @@ -0,0 +1,24 @@
    > > +#ifndef _ASM_X86_FUNC_H
    > > +#define _ASM_X86_FUNC_H
    > > +
    > > +#include <linux/linkage.h>
    > > +#include <asm/asm.h>
    > > +
    > > +/*
    > > + * These are frame pointer save and restore macros. They should be used by
    > > + * every callable non-leaf asm function.
    > > + */
    > > +.macro FP_SAVE name
    > > + .if CONFIG_FRAME_POINTER
    > > + push %_ASM_BP
    > > + _ASM_MOV %_ASM_SP, %_ASM_BP
    > > + .endif
    > > +.endm
    >
    > Hmm. This will not compile when included into .c file. Should it have
    > other extension than .h? (Or can the macros be done in different way?

    These are gnu assembler macros. This file is only included by .S files.

    --
    Josh


    \
     
     \ /
      Last update: 2015-06-10 20:41    [W:4.355 / U:0.292 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site