Messages in this thread | | | Date | Wed, 10 Jun 2015 14:27:43 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf, record: Ammend option summaries |
| |
Em Wed, Jun 10, 2015 at 04:48:50PM +0200, Peter Zijlstra escreveu: > > Because there's too many options and I cannot read, I frequently get > confused between -c and -P, and try to do things like: > > perf record -P 50000 -- foo > > Which does not work; try and make the option description slightly longer > and hopefully less confusing.
Thanks, I'll check and update tools/perf/Documentation/perf-record.txt, i.e. the man page.
- Arnaldo
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> > --- > tools/perf/builtin-record.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index d3731cc..4d6cdeb 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -1027,10 +1027,9 @@ struct option __record_options[] = { > OPT_BOOLEAN('q', "quiet", &quiet, "don't print any message"), > OPT_BOOLEAN('s', "stat", &record.opts.inherit_stat, > "per thread counts"), > - OPT_BOOLEAN('d', "data", &record.opts.sample_address, > - "Sample addresses"), > - OPT_BOOLEAN('T', "timestamp", &record.opts.sample_time, "Sample timestamps"), > - OPT_BOOLEAN('P', "period", &record.opts.period, "Sample period"), > + OPT_BOOLEAN('d', "data", &record.opts.sample_address, "Record the sample addresses"), > + OPT_BOOLEAN('T', "timestamp", &record.opts.sample_time, "Record the sample timestamps"), > + OPT_BOOLEAN('P', "period", &record.opts.period, "Record the sample period"), > OPT_BOOLEAN('n', "no-samples", &record.opts.no_samples, > "don't sample"), > OPT_BOOLEAN('N', "no-buildid-cache", &record.no_buildid_cache,
| |