Messages in this thread | | | Date | Wed, 10 Jun 2015 08:53:25 +0300 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH] tpm, tpm_crb: fix le64_to_cpu conversions in crb_acpi_add() |
| |
On Tue, Jun 09, 2015 at 10:22:40AM -0600, Jason Gunthorpe wrote: > On Tue, Jun 09, 2015 at 02:36:49PM +0300, Jarkko Sakkinen wrote: > > Needs a commit message, bug description, Fixes: header and does it go > to -stable ? > > > Reported-by: Matt Fleming <matt.fleming@intel.com> > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> > > drivers/char/tpm/tpm_crb.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > Obviously there is a problem here with the double swap. But that > should be a nop on x86 hardware, I didn't think there was a BE arch > using ACPI??
No but I don't want to write CRB driver assuming that CRB will be only used on LE platform like x86 even though current HW implementations are only on x86.
> Reviewed-By: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > > Jason
/Jarkko
| |