lkml.org 
[lkml]   [2015]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v5 1/7] mmc: dt-bindings: add Mediatek MMC bindings
    From
    On 10 June 2015 at 04:24, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
    > Document the device-tree binding of Mediatek MMC host
    >
    > Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
    > ---
    > Documentation/devicetree/bindings/mmc/mtk-sd.txt | 32 ++++++++++++++++++++++++
    > 1 file changed, 32 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/mmc/mtk-sd.txt
    >
    > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
    > new file mode 100644
    > index 0000000..a1adfa4
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
    > @@ -0,0 +1,32 @@
    > +* MTK MMC controller
    > +
    > +The MTK MSDC can act as a MMC controller
    > +to support MMC, SD, and SDIO types of memory cards.
    > +
    > +This file documents differences between the core properties in mmc.txt
    > +and the properties used by the msdc driver.
    > +
    > +Required properties:
    > +- compatible: Should be "mediatek,mt8173-mmc","mediatek,mt8135-mmc"
    > +- interrupts: Should contain MSDC interrupt number
    > +- clocks: MSDC source clock, HCLK
    > +- clock-names: "source", "hclk"

    According to the mmc driver, hclk is treated as an optional clock.
    Therefore I think you should list it under an "Optional properties"
    section instead.

    > +- pinctrl-names: should be "default", "state_uhs"
    > +- pinctrl-0: should contain default/high speed pin ctrl
    > +- pinctrl-1: should contain uhs mode pin ctrl
    > +- vmmc-supply: power to the Core
    > +- vqmmc-supply: power to the IO
    > +
    > +Examples:
    > +mmc0: mmc@11230000 {
    > + compatible = "mediatek,mt8173-mmc", "mediatek,mt8135-mmc";
    > + reg = <0 0x11230000 0 0x108>;
    > + interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_LOW>;
    > + vmmc-supply = <&mt6397_vemc_3v3_reg>;
    > + vqmmc-supply = <&mt6397_vio18_reg>;
    > + clocks = <&pericfg CLK_PERI_MSDC30_0>, <&topckgen CLK_TOP_MSDC50_0_H_SEL>;
    > + clock-names = "source", "hclk";
    > + pinctrl-names = "default", "state_uhs";
    > + pinctrl-0 = <&mmc0_pins_default>;
    > + pinctrl-1 = <&mmc0_pins_uhs>;
    > +};
    > --
    > 1.8.1.1.dirty
    >

    Kind regards
    Uffe


    \
     
     \ /
      Last update: 2015-06-10 14:21    [W:3.254 / U:0.652 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site