lkml.org 
[lkml]   [2015]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool()
    On Wed, Jun 10, 2015 at 8:59 PM, Sergey Senozhatsky
    <sergey.senozhatsky.work@gmail.com> wrote:
    > On (06/10/15 17:48), Joe Perches wrote:
    > [..]
    >> > > > For consistency, tweak zpool_destroy_pool() and NULL-check the
    >> > > > pointer there.
    >> > > >
    >> > > > Proposed by Andrew Morton.
    >> > > >
    >> > > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
    >> > > > Reported-by: Andrew Morton <akpm@linux-foundation.org>
    >> > > > LKML-reference: https://lkml.org/lkml/2015/6/8/583
    >> > >
    >> > > Acked-by: Dan Streetman <ddstreet@ieee.org>
    >> >
    >> > Thanks.
    >> >
    >> > Shall we ask Joe to add zpool_destroy_pool() to the
    >> > "$func(NULL) is safe and this check is probably not required" list?
    >>
    >> []
    >>
    >> Is it really worth it?
    >>
    >> There isn't any use of zpool_destroy_pool preceded by an if
    >> There is one and only one use of zpool_destroy_pool.
    >>
    >
    > Yes, that's why I asked. I don't think that zpool_destroy_pool()
    > will gain any significant amount of users soon (well, who knows),
    > so I'm fine with keeping it out of checkpatch checks. Just checked
    > your opinion.

    I really doubt if zpool will be used by anyone other than zswap anytime soon.

    >
    > -ss


    \
     
     \ /
      Last update: 2015-06-11 03:21    [W:2.255 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site