lkml.org 
[lkml]   [2015]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: 2.6.32.66 tcp regression OOPs
    Hi,

    On Mon, Jun 01, 2015 at 09:00:21AM +0200, Frans Klaver wrote:
    > [cc: Willy Tarreau]
    >
    > On Mon, Jun 1, 2015 at 3:26 AM, <starlight.2015q2@binnacle.cx> wrote:
    > > Hello,
    > >
    > > Apoligies if I have submitted to the wrong lists.
    > >
    > > Encountered a regression in
    > > 2.6.32.66 relative to 2.6.32.65.
    > >
    > > Crash eight minutes after boot.
    > >
    > > Will responded with additional details
    > > if the OOPS is not sufficent.
    > >
    > > Best Regards
    > >
    >
    > Did you bisect it?

    Eric Dumazet notified me that of something possibly similar due to
    a mistake I made when backporting a fix by hand.

    Please apply the following patch to see if it fixes the problem :

    diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
    index 5339f066234b..d1e2895bb63c 100644
    --- a/net/ipv4/tcp_output.c
    +++ b/net/ipv4/tcp_output.c
    @@ -2136,7 +2136,7 @@ void tcp_send_fin(struct sock *sk)
    */
    if (tskb && (tcp_send_head(sk) || tcp_memory_pressure)) {
    coalesce:
    - TCP_SKB_CB(skb)->flags |= TCPCB_FLAG_FIN;
    + TCP_SKB_CB(tskb)->flags |= TCPCB_FLAG_FIN;
    TCP_SKB_CB(tskb)->end_seq++;
    tp->write_seq++;
    if (!tcp_send_head(sk)) {

    Thanks,
    Willy



    \
     
     \ /
      Last update: 2015-06-01 10:21    [W:5.466 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site