lkml.org 
[lkml]   [2015]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 05/16] staging: wilc1000: remove time wrapper
Date
On Sunday 31 May 2015 08:58:13 Greg KH wrote:
> On Sat, May 30, 2015 at 12:09:23PM +0530, Sudip Mukherjee wrote:
> > On Fri, May 29, 2015 at 10:52:16PM +0200, Arnd Bergmann wrote:
> > > The abstraction for time in this driver is completely
> > > unused, so remove it.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > > drivers/staging/wilc1000/wilc_osconfig.h | 1 -
> > > drivers/staging/wilc1000/wilc_oswrapper.h | 5 -
> > > drivers/staging/wilc1000/wilc_platform.h | 12 --
> > > drivers/staging/wilc1000/wilc_time.c | 163 ------------------------
> > > drivers/staging/wilc1000/wilc_time.h | 205 ------------------------------
> > > 5 files changed, 386 deletions(-)
> > > delete mode 100644 drivers/staging/wilc1000/wilc_time.c
> > > delete mode 100644 drivers/staging/wilc1000/wilc_time.h
> > after this patch I am getting:
> > "WARNING: could not open drivers/staging/wilc1000/wilc_time.c: No such file or directory"
> >
> > wilc_time is mentioned in the Makefile, it should have been removed from
> > there also.
>
> Ick, not good.

Sorry about that. I had actually made the same mistake before and fixed it up,
but the introduced the bug again and didn't find it during my build testing
because 'make' kept picking up the old object files.

> Arnd, I've applied the first 4 patches, but stopped here, can you respin
> the rest and resend?

Done.

Arnd


\
 
 \ /
  Last update: 2015-06-01 21:41    [W:0.048 / U:6.044 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site