lkml.org 
[lkml]   [2015]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v11 2/12] x86, mm, pat: Refactor !pat_enabled handling
From
Date
On Sun, 2015-05-31 at 11:46 +0200, Borislav Petkov wrote:
> On Fri, May 29, 2015 at 04:59:00PM -0600, Toshi Kani wrote:
> > From: Toshi Kani <toshi.kani@hp.com>
> >
> > This patch refactors the !pat_enabled code paths and integrates
> > them into the PAT abstraction code. The PAT table is emulated by
> > corresponding to the two cache attribute bits, PWT (Write Through)
> > and PCD (Cache Disable). The emulated PAT table is the same as the
> > BIOS default setup when the system has PAT but the "nopat" boot
> > option is specified. The emulated PAT table is also used when
> > MSR_IA32_CR_PAT returns 0 -- 9d34cfdf4796 ("x86: Don't rely on
> > VMWare emulating PAT MSR correctly").
>
> To be honest, I wasn't surprised when you sent me the same patch and
> ignored most of my comments. For the future, please let me know if I'm
> wasting my time with commenting on your stuff so that I can plan my work
> and not waste time and energy reviewing, ok?

I apologize that I overlooked a comment requesting to divide this
refactor patch into smaller patches.

> Unfortunately, if you want something done right, you have to do it
> yourself.
>
> So I did that, I split that ugly cleanup into something much more
> readable, patches as a reply to this message.
>
> Feel free to base your work ontop of
>
> git://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git#tip-mm-2
>

I will look into your changes, and rebase the patchset.

Thanks,
-Toshi



\
 
 \ /
  Last update: 2015-06-01 18:41    [W:0.102 / U:31.156 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site