lkml.org 
[lkml]   [2015]   [Jun]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Cycles annotation support for perf tools v2
    On Wed, May 27, 2015 at 10:51:43AM -0700, Andi Kleen wrote:
    > [v2: Addressed review comments. Fixed display problems and
    > correctly compute IPC now. See patches for detailed changes.]
    >
    > The upcoming Skylake CPU has a new timed branch stack feature,
    > that reports cycle counts for individual branches in the
    > last branch record.
    >
    > This allows to get fine grained cost information for code, and also allows
    > to compute fine grained IPC.
    >
    > Available from
    > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git perf/skl-tools2
    >
    > This patchkit adds support for this in the perf tools:
    > - Basic support for the cycles field like other branch fields
    > - Show cycles in the standard branch sort view (no IPC here,
    > as IPC needs the instruction counts from annotation)
    > - Annotate cycles and IPC in the assembler annotate view
    > - Add branch support to top, so we can do live annotation.
    > - Misc support, like dumping it in perf report -D

    v2 seems ok to me.. all my comments were addressed,
    and I posted one more comment

    anyway, I dont touch annotate code that much to ack annotate
    core patches.. acking only portion of the patchset

    thanks,
    jirka


    \
     
     \ /
      Last update: 2015-06-01 16:41    [W:4.083 / U:0.552 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site