Messages in this thread Patch in this message | | | Date | Mon, 1 Jun 2015 12:56:32 +0300 | From | Dan Carpenter <> | Subject | [patch 2/2] w1: unlock correct lock on error in w1_seq_show() |
| |
Smatch complains that we don't unlock "master->mutex" on this error path. It looks like it is a typo and we unlock ->bus_mutext where ->mutex was intended.
Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/w1/slaves/w1_therm.c b/drivers/w1/slaves/w1_therm.c index 3351be6..79ecaf8 100644 --- a/drivers/w1/slaves/w1_therm.c +++ b/drivers/w1/slaves/w1_therm.c @@ -412,7 +412,7 @@ static ssize_t w1_seq_show(struct device *device, c -= snprintf(buf + PAGE_SIZE - c, c, "%d\n", seq); return PAGE_SIZE - c; error: - mutex_unlock(&sl->master->bus_mutex); + mutex_unlock(&sl->master->mutex); return -EIO; }
| |