lkml.org 
[lkml]   [2015]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] net: mdio-gpio: Allow for unspecified bus id
> >> -	snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id);
> >> + if (bus_id != -1)
> >> + snprintf(new_bus->id, MII_BUS_ID_SIZE, "gpio-%x", bus_id);
> >> + else
> >> + strncpy(new_bus->id, "gpio", MII_BUS_ID_SIZE);
> >
> > Hi Bert
> >
> > What happens if there are multiple platform_device's with -1? You
> > should probably be using use idr_alloc().
>
> It's an instance id per driver, not globally, and -1 specifically means it's
> the only instance. From Documentation/driver-model/platform.txt:

Ah, did not know there can only be one with -1. I've used i2c where
this does not apply when registering adaptors. It will allocate a
unique id to each added with id = -1.

Andrew


\
 
 \ /
  Last update: 2015-05-08 19:01    [W:0.098 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site