lkml.org 
[lkml]   [2015]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] nand: Add NAND driver for Mikrotik RB4xx series boards
On 05/08/2015 12:14 PM, Frans Klaver wrote:
> On Thu, May 7, 2015 at 2:31 PM, Bert Vermeulen <bert@biot.com> wrote:
>> +
>> + info->chip.priv = info;
>> + info->mtd.priv = &info->chip;
>> + info->mtd.owner = THIS_MODULE;
>
> If you should respin, could you add
>
> info->mtd.dev.parent = &pdev->dev;
>
> This will have a symlink to the parent device show up in sysfs. Seems
> some people feel rather strongly about that.

Sure, will do. I'll wait for some comment from David Woodhouse or Brian
Norris first, in case there's something more substantial to fix as well.


--
Bert Vermeulen bert@biot.com email/xmpp


\
 
 \ /
  Last update: 2015-05-08 16:41    [W:0.040 / U:7.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site