lkml.org 
[lkml]   [2015]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 09/10] usb:fsl:otg: Resolve OTG crash issue with another host
Date


> -----Original Message-----
> From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com]
> Sent: Thursday, May 07, 2015 6:32 PM
> To: Mehresh Ramneek-B31383; linux-kernel@vger.kernel.org
> Cc: balbi@ti.com; linux-usb@vger.kernel.org; stern@rowland.harvard.edu;
> gregkh@linuxfoundation.org
> Subject: Re: [PATCH 09/10] usb:fsl:otg: Resolve OTG crash issue with another
> host
>
> Hello.
>
> On 5/7/2015 3:47 PM, Ramneek Mehresh wrote:
>
> > Resolves kernel crash issue when a USB flash drive is inserted into
> > USB1 port with USB2 port configured as otg. Removing "else" block so
> > that the controller coming up in "non-otg" mode doesn't return
> > -ENODEV. Returning "ENODEV" results in platform framework unbinding
> > platform-drv from controller resulting in kernel crash later in hub
> > driver
>
> > Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> > ---
> > drivers/usb/host/ehci-fsl.c | 3 ---
> > 1 file changed, 3 deletions(-)
>
> > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> > index 4bd4b0c..8d55f2b 100644
> > --- a/drivers/usb/host/ehci-fsl.c
> > +++ b/drivers/usb/host/ehci-fsl.c
> > @@ -180,9 +180,6 @@ static int usb_hcd_fsl_probe(const struct hc_driver
> *driver,
> > }
> >
> > ehci_fsl->have_hcd = 1;
> > - } else {
> > - dev_err(&pdev->dev, "wrong operating mode\n");
> > - return -ENODEV;
>
> Isn't it easier to just not add this code in the patch #7?
>
Will do, thanks
> WBR, Sergei



\
 
 \ /
  Last update: 2015-05-08 07:41    [W:0.065 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site