lkml.org 
[lkml]   [2015]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/2] arm64: dts: qcom: Add msm8916 CoreSight components
From
Date

On Fri, 2015-05-08 at 08:13 -0600, Mathieu Poirier wrote:
> On 8 May 2015 at 07:47, Ivan T. Ivanov ivanov@linaro.org> wrote:
> > On Fri, 2015-05-08 at 07:38 -0600, Mathieu Poirier wrote:
> > > On 7 May 2015 at 09:36, Ivan T. Ivanov ivanov@linaro.org> wrote:
> > > > Add initial set of CoreSight components found on Qualcomm's 8x16 chipset.
> > > >
> > > >
> > > > +       replicator@824000 {
> > > > + compatible = "qcom,coresight-replicator", "arm,primecell";
> > >
> > > Shouldn't it be "qcom,coresight-replicator1x" ?
> > >
> >
> >
> >
> > True, I still wonder, why we have to have this compatible string?
> > Drivers are probed by amba_id and "arm,primecell", after all.
> >
>
> Drivers have their own compatible strings for historical reasons,
> something I've been meaning to fix for a long time now...
>

Yep, I see that they have been platform drivers in the past, but now
they are not, except coresight-replicator driver. IMHO, having
additional compatible string could lead just to confusion.

Regards,
Ivan


\
 
 \ /
  Last update: 2015-05-08 16:41    [W:0.090 / U:12.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site