lkml.org 
[lkml]   [2015]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] serial: imx: Revert "initialized DMA w/o HW flow enabled"
On 05/08/2015 01:30 PM, Fabio Estevam wrote:
> On Fri, May 8, 2015 at 4:13 AM, Sebastian Andrzej Siewior
> <sebastian@breakpoint.cc> wrote:
>
>> +
>> + /*
>> + * Can we enable the DMA support? Be aware that
>> + * at least IMX6 needs to load external SDMA firmware in
>> + * order work properly. The in-ROM firmware is not
>> + * wokring properly.
>> + */
>
> On my tests:
>
> Prior to this patch: with the internal ROM SDMA firmware I got UART
> issues when communicating through a Bluetooth module. With external
> SDMA firmware (version 3.1) it worked fine.
>
> With your patch applied: Bluetooth worked fine even with no external
> SDMA firmware, which does not match the comments you added.

Why doesn't it match the comment? The patch disables DMA so the SDMA
firmware does not matter.

> Can't you just remove these comments?
>
> Thanks

Sebastian


\
 
 \ /
  Last update: 2015-05-08 14:01    [W:0.057 / U:96.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site