lkml.org 
[lkml]   [2015]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] mfd: lpc_ich: Assign subdevice ids automatically
Date
Using -1 as platform device id means that the platform driver core will not
assign any id to the device (the device name will not have id at all). This
results problems on systems that have multiple PCHs (Platform Controller
HUBs) because all of them also include their own copy of LPC device.

All the subsequent device creations will fail because there already exists
platform device with the same name.

Fix this by passing -2 as a platform device id. This makes the platform
device core to allocate new ids automatically.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/mfd/lpc_ich.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index 12d960a60ec4..c211cf361680 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -934,7 +934,7 @@ gpe0_done:
lpc_ich_enable_gpio_space(dev);

lpc_ich_finalize_cell(dev, &lpc_ich_cells[LPC_GPIO]);
- ret = mfd_add_devices(&dev->dev, -1, &lpc_ich_cells[LPC_GPIO],
+ ret = mfd_add_devices(&dev->dev, -2, &lpc_ich_cells[LPC_GPIO],
1, NULL, 0, NULL);

gpio_done:
@@ -1008,7 +1008,7 @@ static int lpc_ich_init_wdt(struct pci_dev *dev)
}

lpc_ich_finalize_cell(dev, &lpc_ich_cells[LPC_WDT]);
- ret = mfd_add_devices(&dev->dev, -1, &lpc_ich_cells[LPC_WDT],
+ ret = mfd_add_devices(&dev->dev, -2, &lpc_ich_cells[LPC_WDT],
1, NULL, 0, NULL);

wdt_done:
--
2.1.4


\
 
 \ /
  Last update: 2015-05-08 13:41    [W:0.047 / U:2.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site