lkml.org 
[lkml]   [2015]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on offline cpus


On Wednesday 29 April 2015 10:38 PM, Steven Rostedt wrote:
> On Wed, 29 Apr 2015 21:28:38 +0530
> Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> wrote:
>
>>
>>
>> On Wednesday 29 April 2015 08:48 PM, Steven Rostedt wrote:
>>> On Wed, 29 Apr 2015 20:19:28 +0530
>>> Shreyas B Prabhu <shreyas@linux.vnet.ibm.com> wrote:
>>>
>>>> IIUC there is no existing macro which can both add a condition and
>>>> override printk format, hence the fall back to TRACE_EVENT_CONDITION.
>>>
>>> Hmm, want me to send you a patch that changes that?
>>>
>> I am not sure if its worth the effort now. It doesn't look like any
>> other trace point apart from the above use case will benefit from it.
>> Only smbus_write and smbus_reply seem to come close. But even they need
>> separate TP_fast_assign.
>
> It shouldn't be a problem to implement. But I'm currently cleaning up
> those files, and any changes will cause nasty conflicts.
>
> Lets do this. Push the current changes as is, and when I get around to
> adding a DEFINE_EVENT_PRINT_CONDITION(), we can modify that code to use
> it.
>

Hi Steve,
Do you have any other suggestions for this patchset or will you take
them as is?

Thanks,
Shreyas



\
 
 \ /
  Last update: 2015-05-08 07:01    [W:0.077 / U:1.912 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site