lkml.org 
[lkml]   [2015]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] staging: unisys: remove unused variable
On Fri, May 08, 2015 at 10:34:49AM +0300, Dan Carpenter wrote:
> On Fri, May 08, 2015 at 09:54:44AM +0530, Sudip Mukherjee wrote:
> > On Thu, May 07, 2015 at 10:04:32PM +0200, Greg Kroah-Hartman wrote:
> > > On Thu, May 07, 2015 at 03:06:52PM +0530, Sudip Mukherjee wrote:
> > > > the previous patch of the series made this variable unused.
> > >
> > > What do you mean? There was only one other patch in this series, never
> > > send a patch that causes a build warning.
> > This patch is 2/2 , the 1/2 patch when applied will cause a build
> > warning about unused variable.
> >
> > should i then send a v2 mentioning that "1/2 will cause a build warning
> > which is fixed in 2/2" ?
> >
>
> Gar... No. Fold them together into one patch...
>
> The one thing per patch rule means that you shouldn't do half a thing
> per patch.

already sent that one combined patch.

but this rule is really confusing me now .. :(
if i can understand the devicemodel then this rule should not be tough
to understand.
so, what i understood till now:
1) any patch of the series should not break the build.
(you told me that in my parport patch series :) )

2) any patch of the series should not introduce build warning.

3) when i am modifying some line, i can make simple changes in style.
but if its big change in style then that should be a separate
patch.

regards
sudip

>
> regards,
> dan carpenter
>


\
 
 \ /
  Last update: 2015-05-08 10:01    [W:0.054 / U:37.748 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site