lkml.org 
[lkml]   [2015]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] overflow check calculation in mm/mmap.c is incorrect linux-3.12.38
On Wed, 29 Apr 2015 22:14:19 -0700 "Reese Faucette" <reesefaucette@gmail.com> wrote:

> When checking for overflow, the code in mm/mmap.c compares the first byte
> *after* the end of mapped region to the start of the region instead of the
> last byte of the mapped region. This prevents mapping a region which abuts
> the end of physical space, as mmap() incorrectly rejects the region with
> -EOVERFLOW, because pgoff + (len >> PAGE_SHIFT) will be 0, which is < pgoff.
> -reese
>
> Reese Faucette
> Cisco Systems, Inc.
>
> ====================================================
> --- mm/mmap.c
> +++ mm/mmap.c
> @@ -1241,7 +1241,7 @@
> return -ENOMEM;
>
> /* offset overflow? */
> - if ((pgoff + (len >> PAGE_SHIFT)) < pgoff)
> + if ((pgoff + (len >> PAGE_SHIFT) - 1) < pgoff)
> return -EOVERFLOW;
>
> /* Too many mappings? */

Looks right.

Please send a Signed-off-by: for this patch, as per
Documentation/SubmittingPatches, section 11. Please also let me know
whether the authorship should be you@gmail.com or some Cisco address,
as people often prefer.


\
 
 \ /
  Last update: 2015-05-08 02:01    [W:0.615 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site