lkml.org 
[lkml]   [2015]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 2/3] mm/memblock: Allocate boot time data structures from mirrored memory
From
On Wed, May 6, 2015 at 4:30 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> Gramatically, a function called "memblock_has_mirror()" should return a
> bool. This guy is misnamed. "memblock_mirror_flag()"?

My misnaming is worse than that ... the intent here is to check
whether there is any
mirrored memory in the system ... i.e. should we go looking around
among memblocks
for mirrored memory - or is that a futile quest. Most systems won't
have any mirror
memory - so we won't want to spam the console logs with a ton of messages about
not being able to allocate mirrored memory.

I'll rename it to "system_has_mirror_memory()".

I'll fix all the other things too and re-spin. Keeping to 80 columns
might be challenging in some places.

-Tony


\
 
 \ /
  Last update: 2015-05-07 20:01    [W:0.068 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site