lkml.org 
[lkml]   [2015]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 00/15] HID: hid-lg, hid-lg4ff: Mostly cleanup patches
On Wed, 8 Apr 2015, Michal Malý wrote:

> Hello everyone,
>
> this is a mostly boring series that deals with a few inconsistencies in the
> code that have accumulated over the years. Besides that it patches up a handful
> of problems such a return values not being checked etc.
>
> The only significant change comes in patches 8 through 10 which introduce a
> spinlock to handle concurrent access to the HID report that is used by the
> driver to send data to the wheel. I would appreciate some comments on this one,
> particularly on the way it handles deinitialization. Patches 8 and 9 contain
> the necessary prep work, patch 10 adds the spinlocking.
>
> v2:
> - Split previous patch 7 into three smaller patches
> - Split the long line of text in patch 5 (now patch 6)
> - Add another cleanup patch that removes unnecessary casts from void *

This is a nice cleanup. I've applied it to for-4.2/logitech.

Thanks,

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2015-05-07 16:41    [W:0.063 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site