Messages in this thread | | | Date | Thu, 7 May 2015 16:03:05 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH 05/10] uprobes: Change handle_trampoline() to find the next chain beforehand |
| |
* Oleg Nesterov <oleg@redhat.com> [2015-05-04 14:49:06]:
> No functional changes, preparation. > > Add the new helper, find_next_ret_chain(), which finds the first !chained > entry and returns its ->next. Yes, it is suboptimal. We probably want to > turn ->chained into ->start_of_this_chain pointer and avoid another loop. > But this needs the boring changes in dup_utask(), so lets do this later. > > Change the main loop in handle_trampoline() to unwind the stack until ri > is equal to the pointer returned by this new helper. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Looks good to me.
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> -- Thanks and Regards Srikar Dronamraju
| |