lkml.org 
[lkml]   [2015]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] mm/memblock: Add extra "flag" to memblock to allow selection of memory based on attribute
On Wed, 29 Apr 2015 11:31:24 -0700 Tony Luck <tony.luck@intel.com> wrote:

> No functional changes
>
> ...
>
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -61,7 +61,7 @@ extern bool movable_node_enabled;
>
> phys_addr_t memblock_find_in_range_node(phys_addr_t size, phys_addr_t align,
> phys_addr_t start, phys_addr_t end,
> - int nid);
> + int nid, u32 flag);

Sometimes this is called "flag", other times it is called "flags". Can
we please be consistent? "flags" seems to be the way to go.

Also, memblock_region.flags has type unsigned long, but you've used
u32. ulong seems better.




\
 
 \ /
  Last update: 2015-05-07 02:01    [W:0.120 / U:0.244 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site