Messages in this thread | | | Date | Wed, 6 May 2015 19:32:42 -0300 | Subject | Re: [PATCH] iio: hid-sensors: Fix memory leak on failure path in hid_prox_probe() | From | Fabio Estevam <> |
| |
On Wed, May 6, 2015 at 7:14 PM, Alexey Khoroshilov <khoroshilov@ispras.ru> wrote:
> Not exactly. Other calls are after > indio_dev->channels = channels; > So, > error_free_dev_mem: > kfree(indio_dev->channels); > works for them well.
indio_dev is allocated using devm_ , so you don't need to free it.
Your patch is not correct because you only kfree(channels) in the prox_parse_report() error case, but you missed the other subsequent functions.
| |